Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update issue template for feature proposal #1291

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Jul 17, 2020

New template for the feature proposal as discussed in discord.

Rendered Template

@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/o6vfc9d6u
✅ Preview: https://docsify-preview-git-issue-template-for-feature-request.docsify-core.vercel.app

@anikethsaha anikethsaha requested a review from a team July 17, 2020 16:24
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 301016a:

Sandbox Source
docsify-template Configuration

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sy-records sy-records requested a review from a team July 19, 2020 01:05
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is only for contributors I think it is really good, which has enough details to assess feasibility .
but I wonder if it is for all users who want request a feature. if so, it seems more complicated.

As product users, I guess they couldn't fill in the template very well , especially the analysis of the change influences.
so, I think the Drawbacks and BCA could be optional but recommend users to think about it.

@Koooooo-7 Koooooo-7 requested a review from a team July 19, 2020 03:01
@sy-records
Copy link
Member

Maybe we could add a new template instead of modifying this one.

@trusktr
Copy link
Member

trusktr commented Jul 19, 2020

In general most people are too lazy to file issues on libs to begin with. So the simpler the better? What if it were simpler for feature requests, and we get a new template for RFCs?

@anikethsaha
Copy link
Member Author

If it is only for contributors I think it is really good, which has enough details to assess feasibility .
but I wonder if it is for all users who want request a feature. if so, it seems more complicated.

As product users, I guess they couldn't fill in the template very well , especially the analysis of the change influences.
so, I think the Drawbacks and BCA could be optional but recommend users to think about it.

This is for the contributors or someone who is willing to contribute or wants a new feature.
Yea I think it would be good to make the BCA optional, not sure about drawbacks.

Maybe we could add a new template instead of modifying this one.

In general most people are too lazy to file issues on libs to begin with. So the simpler the better? What if it were simpler for feature requests, and we get a new template for RFCs?

The only thing concerning me is that how to differentiate RFC and a feature request?
I think they are the same if they are related to the core part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants