-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert {docsify-ignore} and {docsify-ignore-all} to HTML comments #1318
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/n5ph96a7z |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 936cab3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should we be compatible with previous versions? @anikethsaha
If we want to solve #767 whit this PR, i think should not be compatible. |
I think it should be backward compatibility. we'd better keep current congratulation and allowed the new one. |
This is how dependencies work. If you don't specify a version you will get the last version, including any Who is using Assuming this fix will shipped with v5:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how dependencies work. If you don't specify a version you will get the last version, including any
major
releases that always include breaking changes. Users should know how how to use it.Who is using
@3
will not get this fix since i think it will be shipped with v4 (?). Who is using docsify without a specified version will automatically get the v4 with their relative breaking changes, including this one (personally, i think this is not a good usage)
make sense, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Can we have some test for this change ?
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool 👍🏻
Ref and close #441
This should also close #767
Summary
This PR prevents
{docsify-ignore}
and{docsify-ignore-all}
to be rendered inside other markdown engines like on Github.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Tests