Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing argument for highlighting code #1365

Merged
merged 1 commit into from
Sep 1, 2020
Merged

fix: add missing argument for highlighting code #1365

merged 1 commit into from
Sep 1, 2020

Conversation

smalluban
Copy link
Contributor

Summary

the Prism highlight() method requires three arguments:

(static) highlight(text, grammar, language) → {string}

The last one should be the name of the language. Without the third argument, the js-templates (components/prism-js-templates.js) component does not work (for highlighting template literals).

Without the third argument:

Zrzut ekranu 2020-09-1 o 10 07 49

With the third argument:

Zrzut ekranu 2020-09-1 o 10 08 38

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/74w9mscyt
✅ Preview: https://docsify-preview-git-fork-hybridsjs-develop.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 028ef2a:

Sandbox Source
docsify-template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants