Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Theme preview in IE11 #1502

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Fix: Theme preview in IE11 #1502

merged 2 commits into from
Feb 10, 2021

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented Feb 9, 2021

Summary

IE11 was throwing an error when loading the "Themes" page due to missing semicolons in the page <script>.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Docs

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/ef8w9bqvd
✅ Preview: https://docsify-preview-git-fix-ie11-theme-switcher.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd6dba3:

Sandbox Source
docsify-template Configuration

@jhildenbiddle jhildenbiddle requested a review from a team February 9, 2021 05:38
@jhildenbiddle jhildenbiddle merged commit 8cda078 into develop Feb 10, 2021
@jhildenbiddle jhildenbiddle deleted the fix-ie11-theme-switcher branch February 10, 2021 05:27
@sy-records sy-records mentioned this pull request Mar 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants