Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve basic layout style #884

Merged
merged 2 commits into from
Mar 9, 2020
Merged

improve basic layout style #884

merged 2 commits into from
Mar 9, 2020

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 14, 2019

Summary

Improve basic layout style a little.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: UI change

If changing the UI of default theme, please provide the before/after screenshot:

Before After
chrome_USCjuix3I3 chrome_EwsWCoKGVR
Z7BNw0ZmFQ 9Ev9NJW8Ig

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@anikethsaha
Copy link
Member

Please rebase

@kidonng kidonng changed the base branch from master to develop February 27, 2020 02:04
@anikethsaha anikethsaha merged commit 5d541dd into docsifyjs:develop Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants