Fix #914

[vkallore]

Summary
Fixes #914
Had raiesed an issue #914 on missing rel="noreferrer noopener" for links opening in new tab/window and done the fix with 'noopener' for links with _blank. Thought not to add 'noreferrer' as it might be useful for referrer info.

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

---

• DO NOT include files inside lib directory.

[anikethsaha]

the motive is to stop opening new tabs right ?
it can be done using _self as well in the target.

Anything extra this is doing ?

[vkallore]

Its not to prevent opening in new tab. Read about the risk of not adding it here

[anikethsaha]

Its not to prevent opening in new tab. Read about the risk of not adding it here

ahh...make sense. What is the behavior of this PR when externallinktarget is _blank and _self ?

[vkallore]

As you can see in this PR commit #4769018, if the dev forgot to add the externalLinkRel, script will default it to 'noopener' (also read the PR summary). Dev is also allowed to add as required (empty or different as per demands).

Does it make sense?

[anikethsaha]

I read the description already. What I was asking is whats the behavior of having both externalLinkRel and externalLinktarget ?

[vkallore]

Well, its required only for _blank. It has no effect if any other config value found for linkTarget.

[anikethsaha]

SO if _blank is provided, and this options is set to noopener (which is by default)` so the blank wont wok right ?

[vkallore]

_blank continues to work as expected. Only addition is ... rel="blah..."... for the <a> tags.

[anikethsaha]

ohh.....I got it. noopener is for stopping the referer headers to pass.

Ok this is a valid fix.

Could You rebase and fix the conflicts. And then we are good to go 👍

[vkallore]

Resolved the conflicts.

[anikethsaha]

Thanks for the PR 🙏