Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip indent when embedding code fragment #996

Merged

Conversation

Fs02
Copy link
Contributor

@Fs02 Fs02 commented Jan 5, 2020

Summary

This pr fixes wrong indentation when embedding fragment of code.

Code:

image

Before:

image

After:

image

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@anikethsaha
Copy link
Member

Thanks for the PR.
Can you please with some indentation based language formatting like for python? Cause changing the indentation affects the code.

@Fs02
Copy link
Contributor Author

Fs02 commented Jan 6, 2020

Hi, in that case, the current code is already causing some indentation problem for python.
example:

image

Before:

image

After:

image

Note: I also edited the PR description to provide the original code.

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is much better

@Fs02
Copy link
Contributor Author

Fs02 commented Jan 11, 2020

Thanks. This is much better

Hi @anikethsaha, is there anything I need to do to have this merge? or should I just wait?

Thanks

@anikethsaha anikethsaha merged commit 4f48679 into docsifyjs:develop Jan 11, 2020
@anikethsaha
Copy link
Member

Sorry for the delay

@Fs02
Copy link
Contributor Author

Fs02 commented Jan 11, 2020

No problem, thank you :)

@Fs02 Fs02 deleted the strip-indent-when-embedding-code branch January 11, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants