Use the Persistence Proxy interface for checking ORM proxy objects #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 162 162
Lines 8457 8457
=======================================
Hits 6712 6712
Misses 1745 1745
☔ View full report in Codecov by Sentry. |
franmomu
approved these changes
Oct 30, 2023
phansys
reviewed
Nov 5, 2023
| @@ -32,7 +32,7 @@ public function getIdentifier($om, $object, $single = true) | |||
| } | |||
|
|
|||
| if ($om instanceof EntityManagerInterface) { | |||
| if ($object instanceof ORMProxy) { | |||
| if ($object instanceof PersistenceProxy) { | |||
There was a problem hiding this comment.
I'm wondering if relaxing this check deserves an entry in the changelog, since previous to this change only instances of Doctrine\ORM\Proxy\Proxy were admitted in this condition.
There was a problem hiding this comment.
I'd say this is more of an internal change to match the upstream API changes and not a deliberate feature change in this package. So not necessarily something that needs to be called out in a changelog entry.
|
thanks @mbabker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2708
In ORM 2.14,
Doctrine\ORM\Proxy\Proxywas deprecated and the upgrade guide suggests usingDoctrine\Persistence\Proxyinstead, with the ORM interface removed in 3.0. This updates all checks to reflect this deprecation.