Doctrine\ORM\Mapping\ClassMetadata::getFieldMapping() will return an object on ORM 3 instead of an array #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object on ORM 3 instead of an array
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
+ Coverage 78.75% 78.91% +0.16%
==========================================
Files 163 163
Lines 8593 8502 -91
==========================================
- Hits 6767 6709 -58
+ Misses 1826 1793 -33 ☔ View full report in Codecov by Sentry. |
franmomu
approved these changes
Feb 13, 2024
|
thanks @mbabker! |
This was referenced Apr 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2708
Cherry-picks out changes related to moving from an array to the
Doctrine\ORM\Mapping\FieldMappingin ORM 3.0.The compat issues are baselined into the PHPStan config for now since we know the class doesn't exist on 2.18 (which is what SA is running against) and the entire point of this diff is to be a compat layer.