Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal trait to allow cross-version compatibility for ORM hydrators #2804

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 28, 2024

Ref: #2708

Similar to #2758 this adds a trait to help with cross-version compatibility, this time for the ORM hydrators and their changed signatures. Flat-out adding return types would be treated as a B/C break, so that can't be done cleanly until a 4.0 release, so this trait helps to cover those changes in an easily replaced way when the bridge is no longer needed.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (0632ab1) to head (32b60b3).
Report is 20 commits behind head on main.

Files Patch % Lines
src/Tool/ORM/Hydration/HydratorCompat.php 68.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
+ Coverage   78.75%   78.91%   +0.16%     
==========================================
  Files         163      164       +1     
  Lines        8593     8519      -74     
==========================================
- Hits         6767     6723      -44     
+ Misses       1826     1796      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu merged commit ce938ac into doctrine-extensions:main Jun 9, 2024
29 of 34 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @mbabker!

@mbabker mbabker deleted the hydrator-compat branch June 9, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants