Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Loggable] Support embeddable xml mapping #2846

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −1
Open

[Loggable] Support embeddable xml mapping #2846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f62ca5c
[Loggable] Support embeddable xml mapping
eytanProxi Jul 23, 2024
87eacd1
Update CHANGELOG.md
eytanProxi Jul 23, 2024
af7c7e7
[Loggable] Support embedded document xml mapping
eytanProxi Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ a release.
---

## [Unreleased]
### Added
- Loggable: Support embeddable xml mapping
Copy link
Collaborator

@phansys phansys Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Loggable: Support embeddable xml mapping
- Loggable: Support embedded mapping in the XML driver


## [3.16.1]
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/Loggable/Mapping/Driver/Xml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function readExtendedMetadata($meta, array &$config)

$xml = $xml->children(self::GEDMO_NAMESPACE_URI);

if (in_array($xmlDoctrine->getName(), ['mapped-superclass', 'entity', 'document'], true)) {
if (in_array($xmlDoctrine->getName(), ['mapped-superclass', 'entity', 'document', 'embeddable', 'embedded-document'], true)) {
if (isset($xml->loggable)) {
/**
* @var \SimpleXMLElement;
Expand Down
Loading