Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use QCNs for fixture classes #2854

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phansys
Copy link
Collaborator

@phansys phansys commented Aug 19, 2024

Originally, the motivation for using constants for the fixture classes was the lack of a proper reference to these classes.
Now, we can use the ::class pseudo constant with the QCNs instead of its hardcoded string representation.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (0632ab1) to head (c3a8c2a).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   78.75%   78.84%   +0.09%     
==========================================
  Files         163      167       +4     
  Lines        8593     8638      +45     
==========================================
+ Hits         6767     6811      +44     
- Misses       1826     1827       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys phansys marked this pull request as ready for review August 19, 2024 23:25
@phansys phansys requested a review from franmomu August 19, 2024 23:25
@phansys phansys force-pushed the test_fixture_classes branch 3 times, most recently from efcdeca to 7546d9a Compare August 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant