Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace asserting doctrine is instance of Registry with assert it is proper interface #401

Merged
merged 1 commit into from
Feb 12, 2021
Merged

replace asserting doctrine is instance of Registry with assert it is proper interface #401

merged 1 commit into from
Feb 12, 2021

Conversation

slawro
Copy link

@slawro slawro commented Feb 11, 2021

see #400

@greg0ire
Copy link
Member

greg0ire commented Feb 11, 2021 •
edited
Loading

I'm having a look at the static analysis issue.

In the meantime,

  • please improve your commit message according to the contributing guide. In your case, it's more about the form than about the contents 👍
  • please associate your email address with your Github account, or change the
    email in your commits to an address already associated with it. If you do not
    want to expose your personal email address, you may use
    [email protected], that way we can still reach you through Github.
    Additionally, you will get credit for this contribution on your Github profile.

@greg0ire

This comment has been minimized.

Sign in to view
@greg0ire greg0ire closed this Feb 12, 2021
@greg0ire greg0ire reopened this Feb 12, 2021
@slawro
replace asserting doctrine is instance of Registry with assert it is …
861963e 
…proper interface

doctrine migration commands is showing warning when using custom implemetation of doctrine manager
this is why ive changed assert instance of Registry to assert instance of ManagerRegistry interface
as only one method getManagerNames is used that is declared in this interface
Fixes doctrine#400
@slawro slawro force-pushed the doctrine-command-helper-assert-fix branch from 3176982 to 861963e Compare February 12, 2021 09:25
@slawro
Copy link
Author

slawro commented Feb 12, 2021

@greg0ire thank you very much for help and suggestions, it is very helpful from You

ive changed what you suggested, hope that all is correct now
let me know if you have any other suggestions

@greg0ire greg0ire requested a review from goetas February 12, 2021 19:53
@greg0ire greg0ire linked an issue Feb 12, 2021 that may be closed by this pull request
Warning: assert(): assert($doctrine instanceof Registry) failed when you have custom implementation of ManagerRegistry #400
Closed
@greg0ire greg0ire added this to the 2.2.3 milestone Feb 12, 2021
@greg0ire greg0ire merged commit ecf9184 into doctrine:2.2.x Feb 12, 2021
@greg0ire
Copy link
Member

Thanks @slawro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@goetas goetas Awaiting requested review from goetas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.3
2 participants
@slawro @greg0ire