-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 6 #434
Allow Symfony 6 #434
Conversation
We should wait a bit before allowing Symfony 6 because we're still breaking BC there (eg adding return types). |
Converting to draft until the right moment. |
Fyi, all types have been added and work on this PR can resume :) |
Can you please rebase and resolve the conflicts? |
Done, however I think it won't works because I can't set Composer's Should we wait for Symfony 6 official release to re-run this PR's checks? |
@greg0ire Can you have a look, please? |
ed27345
to
fe01803
Compare
I've tried something, but it's getting late, and I have to think this through a bit more (the extra prefer-lowest job and upload coverage job seem wrong) |
I removed my commit because I cannot find a satisfying solution. I think in this case, we should partially revert 739d439, or just maintain an MR open that sets the stability in composer.json to dev, and merge it (after dropping the commit that does this) once Symfony 6 comes out. Having a workflow that oscillates between a custom version and a generic one does not sound great. |
@greg0ire But adjusting the minimum stability for a CI job is not a very uncommon need. Wouldn't it be possible to add an optional parameter to the workflow that would result in a |
We would also need an extra job under |
0fa2a98
to
ec04d87
Compare
I see. Would it be possible to decouple the workflow from the matrix? My idea would be to have one parameterized This way, we could add additional parameters to the |
Psalm's |
Co-authored-by: Grégoire Paris <[email protected]> Co-authored-by: Alexander M. Turek <[email protected]> Signed-off-by: Alexander M. Turek <[email protected]>
Yes, that would be possible and was in fact quite similar to what I did with my previous attempt. There are things left to get right though, like how to upload coverage. I'll give it another try. |
My new attempt can be seen at #456 |
No description provided.