Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type declaration to suspend the deprecated info message #442

Merged

Conversation

vikbert
Copy link
Contributor

@vikbert vikbert commented Oct 3, 2021

Added the explicit @return to suspend the deprecation info msg as showed in the following:

➜ dcphp bin/console c:c
Xdebug: [Step Debug] Could not connect to debugging client. Tried: host.docker.internal:9003 (through xdebug.client_host/xdebug.client_port) :-(

 // Clearing the cache for the dev environment with debug true

 [OK] Cache for the "dev" environment (debug=true) was successfully cleared.

2021-10-03T20:24:45+02:00 [info] User Deprecated: Method "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::getName()" might add "string" as a native return type declaration in the future. Do the same in implementation "Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector" now to avoid errors or add an explicit @return annotation to suppress this message.

@greg0ire greg0ire merged commit 2cb708c into doctrine:3.1.x Oct 3, 2021
@greg0ire
Copy link
Member

greg0ire commented Oct 3, 2021

Thanks @vikbert !

@greg0ire greg0ire added this to the 3.1.2 milestone Oct 3, 2021
@vikbert
Copy link
Contributor Author

vikbert commented Oct 3, 2021

thx for the quick code review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants