Added support for Configuration#setTransactional() configuration in doctrine/doctrine-migrations-bundle
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `doctrine/doctrine-migrations-bundle` This patch introduces a way to set `Configuration#setTransactional()` via DIC parameters, introduced in doctrine/migrations#1157, but never implemented at configuration level. Ref: doctrine/migrations#1157 Ref: doctrine/migrations#1153
Ocramius
commented
Oct 19, 2021
Ocramius
commented
Oct 19, 2021
|
Whoops, seems like this was already handled by #432 (unreleased), hence why I repeated the effort. |
|
@greg0ire closing as |
|
Sorry, I missed @alshenetsky's comment, probably a case of holidays and then I came back and cleared my inbox 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a way to set
Configuration#setTransactional()via DIC parameters, introducedin doctrine/migrations#1157, but never implemented at configuration level.
Ref: doctrine/migrations#1157
Ref: doctrine/migrations#1153
@greg0ire note: I've set the milestone to
3.2.0, but beware that the current default branch is3.1.x- unsure why