Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return void annotation to suppress deprecation warnings in Bundle::build() #494

Merged
merged 1 commit into from
May 2, 2023
Merged

Added return void annotation to suppress deprecation warnings in Bundle::build() #494

merged 1 commit into from
May 2, 2023

Conversation

mickverm
Copy link
Contributor

@mickverm mickverm commented May 2, 2023

When version 3.2.2 of this bundle is used together with Symfony 6.3 (Symfony 6.3.0-BETA1), the following warning is logged:

Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

@greg0ire greg0ire merged commit 05490c7 into doctrine:3.2.x May 2, 2023
@greg0ire greg0ire added this to the 3.2.3 milestone May 2, 2023
@greg0ire
Copy link
Member

greg0ire commented May 2, 2023

Thanks @mickverm !

@mickverm mickverm mentioned this pull request May 2, 2023
@mickverm mickverm deleted the return-type-deprecation branch May 2, 2023 13:26
@ruudk
Copy link

ruudk commented May 31, 2023

Thanks for fixing this. Since Symfony 6.3 is released, it would be great to have this fix tagged.

@greg0ire
Copy link
Member

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants