Deprecate ContainerAwareMigrationFactory #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
deprecate/container-aware
branch
from
525b92b
to
b53c122
Compare
derrabus
force-pushed
the
deprecate/container-aware
branch
from
b53c122
to
97a1b46
Compare
derrabus
commented
Nov 13, 2023
| @@ -3,7 +3,7 @@ | |||
| errorLevel="4" | |||
| phpVersion="8.2" | |||
| findUnusedBaselineEntry="true" | |||
| findUnusedCode="true" | |||
| findUnusedCode="false" | |||
There was a problem hiding this comment.
For some reason, Psalm starts to detect classes used by DoctrineMigrationsExtensionTest as "unused" after my change. My motivation to investigate that is rather limited, I must admit. 😓
greg0ire
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerAwareInterfacewill be removed in Symfony 7 which rendersContainerAwareMigrationFactoryuseless. I'm therefore deprecating this feature.I realize that we don't have a replacement (yet), but since we already know that we can't keep this feature, we might as well deprecate it now. Someone who uses that feature might want to step forward and build a replacement.