Remove redundant implementation of PDO\SQLSrv\Connection::lastInsertI…

…d($name)
doctrine · Mar 31, 2021 · 24b1f9a · 24b1f9a
1 parent 012569d
commit 24b1f9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -365,8 +365,8 @@ jobs:
           - "7.4"
           - "8.0"
         extension:
-          - "sqlsrv"
-          - "pdo_sqlsrv"
+          - "sqlsrv-5.9.0"
+          - "pdo_sqlsrv-5.9.0"
         collation:
           - "Latin1_General_100_CI_AS"
         include:

diff --git a/src/Driver/PDO/SQLSrv/Connection.php b/src/Driver/PDO/SQLSrv/Connection.php
@@ -49,13 +49,7 @@ public function exec(string $sql): int
      */
     public function lastInsertId($name = null)
     {
-        if ($name === null) {
-            return $this->connection->lastInsertId($name);
-        }
-
-        return $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?')
-            ->execute([$name])
-            ->fetchOne();
+        return $this->connection->lastInsertId($name);
     }
 
     /**