[GH-4510] Deprecate ReservedWordsCommand::setKeywordListClass() #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4510.
The usage of
ReservedWordsCommand::setKeywordListClass()is being deprecated in favor ofsetKeywordList(). This way, the DBAL will be no longer responsible for unsafe instantiation of classes with unknown constructor signature.Additionally, the list of keyword lists has been sorted alphabetically and the command help message has been corrected: all keyword lists are used by default including the IBM DB2 list.