Implement binary array parameter type #5994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Apr 6, 2023
|
The DB2 failure appears to be related to your changes. |
|
Tests are still failing for DB2. |
derrabus
reviewed
Apr 10, 2023
Comment on lines
+111
to
+114
| case ParameterType::BINARY: | ||
| $this->bind($param, $variable, DB2_PARAM_IN, DB2_BINARY); | ||
| break; | ||
|
|
There was a problem hiding this comment.
Your feature should not require a change in the drivers because array parameter expansion happens before the statement hits the driver. If binary parameters didn't need special treatment before, they shouldn't now.
|
Rebase needed. @AndriusUkelis Do you have time to answer to my comment? @phansys Can you assist with getting this to work on DB2? |
Sure, I'll try! But please, be patient. I'm a little bit out of scope these weeks. |
Merged
|
Closing in favor of #6134. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Doctrine does not support ArrayParameterType::BINARY, thus when trying to query data with binary parameters (some hash for example) - you get no results.
Spotted this when I was working with Sqlite3 driver and trying to query data by binary id column.