Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add MySQL 9, reduce test matrix #6462

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 3, 2024

MySQL 9 has been released and 8.4 has been declared to be the LTS release. I've added MySQL 9 to the test matrix and took the opportunity to shrink the test matrix a little. Our CI is othen blocked because of too many concurrent jobs, so we might not want to test all possible permutations of PHP and MySQL versions.

Taking into account that we're going to maintain the 3.x branch for a little longer, we need a strategy for not letting the test matrix grow exponentially with every future PHP or DBMS release.

My proposal for MySQL:

  • Test all supported MySQL versions (currently: 5.7, 8.0, 8.4, 9.0) with the latest PHP version (currently 8.3).
  • Test the oldest supported PHP release (currently 7.4) against one release only (MySQL 8.0) only.

All other PHP releases are tested against SQLite already.

If this proposal is accepted, I'd like to work out a similar strategy for the other supported DBMS. I think we should also document that strategy properly then.

@derrabus derrabus marked this pull request as ready for review July 4, 2024 10:54
@greg0ire
Copy link
Member

greg0ire commented Jul 4, 2024

I think we should also document that strategy properly then.

Yes, specifically, it would be great to cover what we are expecting to catch here. For instance, what would make the build for fail for 8.0 but wouldn't make any other job fail?

@greg0ire
Copy link
Member

greg0ire commented Jul 6, 2024

My point is that maybe some part of the matrix should be extracted into scheduled runs, if it's going to be caused by new releases of RDBMS.

@derrabus
Copy link
Member Author

My point is that maybe some part of the matrix should be extracted into scheduled runs, if it's going to be caused by new releases of RDBMS.

In scheduled runs, we should test a more complete matrix if we wanted that. None of the jobs in the matrix I'm proposing is aiming at detecting issues with new releases.

Do you have any further remarks or questions on the matrix I'm proposing for MySQL at the moment? I'd like to get this merged up so we get coverage for MySQL 9 everywhere.

@derrabus derrabus added this to the 3.8.7 milestone Jul 16, 2024
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that was my only question

@derrabus derrabus merged commit b35648d into doctrine:3.8.x Jul 16, 2024
85 of 86 checks passed
@derrabus derrabus deleted the ci/mysql-9 branch July 16, 2024 10:45
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 3.8.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Complete sentence
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 3.8.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Complete sentence
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 3.8.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Complete sentence
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 4.0.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Fix update/delete aliases in documentation (doctrine#6470)
  Complete sentence
  Docs: update custom platform example to use middlewares (doctrine#6460)
  ci: nightly - php-8.1 only + workflow_dispatch
  ci: nightly - php-8.1 min version (doctrine#6457)
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 4.1.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  Add SmallFloat type (doctrine#6471)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Fix update/delete aliases in documentation (doctrine#6470)
  Complete sentence
  Docs: update custom platform example to use middlewares (doctrine#6460)
  ci: nightly - php-8.1 only + workflow_dispatch
  ci: nightly - php-8.1 min version (doctrine#6457)
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants