Make the schema manager aware of the disabling of type comments #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the schema comparison will not remove existing type comments when disabling them because it will still silently remove that part of the comment during introspection (and so won't detect an expected change between the expected empty comment and the introspected comment). Disabling that stripping logic when disabling type comments corresponds to the behavior of DBAL 4 regarding comments, which is exactly what the configuration option is about.
stof
force-pushed
the
fix_type_comment_removal
branch
from
43e1b03
to
8ce05ed
Compare
greg0ire
approved these changes
Aug 6, 2024
|
Before this PR, the configuration setting would work fine in new projects and for new fields in existing projects, but would not clean the DB schema for existing fields (until upgrading to 4.0) |
SenseException
approved these changes
Aug 6, 2024
|
Testing an updated merge commit. |
|
Thanks @stof ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the schema manager aware of the disabling of type comments to disable its special handling of the type comments during introspection.
Without this change, the schema comparison will not remove existing type comments when disabling them because it will still silently remove that part of the comment during introspection (and so won't detect an expected change between the expected empty comment and the introspected comment).
Disabling that stripping logic when disabling type comments corresponds to the behavior of DBAL 4 regarding comments, which is exactly what the configuration option is about.