Use generators for large data providers #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/yield-data-providers
branch
from
ab25c9f
to
e6ecb24
Compare
greg0ire
approved these changes
Aug 28, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Aug 28, 2024
* 3.9.x: Use generators for large data providers (doctrine#6508) PHPStan 1.12 (doctrine#6507)
You make make it a bit better with this option:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While merging 3.9.x I found myself debugging PHPStan errors in the humongous array shape that is the
dataExpandListParametersdata provider. I'd like to use a generator function instead which should give us more precise static analysis results in the future.These are mostly whitespace changes. GitHub's default diff view is not very helpful, I'm afraid. 🙈