Distinguish between Appveyor and github-action

[greg0ire]

Right now, the Codecov UI displays downloads in a confusing way: You get an "appveyor" header, and then 2 list items with links to appveyor, followed by one list item with a link to Github.

We didn't specify that appveyor name anywhere, maybe Codecov behaves differently on that platform. Let us see if specifying a name in the github action that uploads to Codecov allows to clarify things.

☝️ screenshot from https://app.codecov.io/github/doctrine/dbal/commit/976f3f374e25806542d789dba2f813db31274d40

The last link leads to https://github.com/doctrine/dbal/actions/runs/11615595861

[greg0ire]

Result:

It does not look like a new section is going to be created, but at least the link is named now, so this should be less confusing.

I couldn't find Appveyor-specific codecov documentation explaining how or why this happens.

[SenseException]

I just peeked into the codecov.sh file that's downloaded by the Appveyor config and it looks like there are some Appveyor specific variables that can be used.

Random example snippet from the bash script:

elif [[ "$CI" = "true" || "$CI" = "True" ]] && [[ "$APPVEYOR" = "true" || "$APPVEYOR" = "True" ]];
then
  say "$e==>$x Appveyor CI detected."
  # http://www.appveyor.com/docs/environment-variables
  service="appveyor"
  branch="$APPVEYOR_REPO_BRANCH"
  build=$(urlencode "$APPVEYOR_JOB_ID")
  pr="$APPVEYOR_PULL_REQUEST_NUMBER"
  job="$APPVEYOR_ACCOUNT_NAME%2F$APPVEYOR_PROJECT_SLUG%2F$APPVEYOR_BUILD_VERSION"
  slug="$APPVEYOR_REPO_NAME"
  commit="$APPVEYOR_REPO_COMMIT"
  build_url=$(urlencode "${APPVEYOR_URL}/project/${APPVEYOR_REPO_NAME}/builds/$APPVEYOR_BUILD_ID/job/${APPVEYOR_JOB_ID}")

Maybe there's also a variable to name it for Appveyor if needed.

[greg0ire]

Maybe there's also a variable to name it for Appveyor if needed.

Thanks, I found a cli option 🙂

[greg0ire]

That didn't work great…

[greg0ire]

Now trying the slightly more complicated syntax I've seen elsewhere in the file.

[derrabus]

Feel free to merge once you're feeling confident about your changes.

[greg0ire]

The alternate syntax doesn't work either… I'm quite puzzled 🤔

[greg0ire]

Ah that would be because you have to use ps: to enable powershell syntax, it seems.

[greg0ire]

Running a bash script with Powershell does not seem to work great :/

[greg0ire]

Finally!