Added mysqli driver. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,56 @@ | |||
| <?php | |||
| /* | |||
| * $Id$ | |||
There was a problem hiding this comment.
this line is a leftt-over from the SVN legacy. You should not include it in new files.
| $values = $this->_fetch(); | ||
| if (null === $values) { | ||
| return null; | ||
| } elseif (false === $values) { |
There was a problem hiding this comment.
you should use if instead of elseif here. and you should probably use $this->fetch(\PDO::FETCH_NUM) instead of $this->_fetch() to avoid duplicating the logic creating the exception
…. Added MysqlConnection::getWrappedResourceHandle(). MysqliStatement::fetchAll() now decide fetch style if none is set, instead of letting fetch() do it on every call.
… exception if a error had a occured.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes Dbal and ORM tests.
Some primitive "time" cmd of tests is slower then pdo_mysql, all suggestions are welcome :)