Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let composer decide the best version #1032

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Conversation

PowerKiKi
Copy link
Contributor

Q A
Type dcos
BC Break no
Fixed issues none

Summary

Let composer decide the best version, instead of hardcoding somehting in the docs.

@greg0ire
Copy link
Member

greg0ire commented Jul 3, 2020

This should probably target a lower branch.

@goetas
Copy link
Member

goetas commented Jul 4, 2020

@PowerKiKi can you target 2.3.x with your change?

@PowerKiKi PowerKiKi changed the base branch from master to 2.3.x July 4, 2020 08:54
@PowerKiKi PowerKiKi changed the base branch from 2.3.x to master July 4, 2020 08:56
@PowerKiKi PowerKiKi changed the base branch from master to 2.3.x July 4, 2020 09:10
@PowerKiKi
Copy link
Contributor Author

done

@goetas goetas merged commit 100e85a into doctrine:2.3.x Jul 4, 2020
@goetas goetas added this to the 2.3.0 milestone Jul 4, 2020
@goetas
Copy link
Member

goetas commented Jul 4, 2020

thank you!

@PowerKiKi PowerKiKi deleted the patch-2 branch October 29, 2020 01:14
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants