Drop support for silencing errors about DDL in transactions #1300
+42
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the helper class is kept in 4.0, it can only be removed in a 5.0 release, right? It doesn't seem to be widely in use now. |
|
I think the choice is between removing it in 4.0, or keeping it forever, for DX reasons. |
|
The method naming is odd now. The names end with |
|
Ok, I'll switch to just |
I hesitated between this and removing the transaction helper entirely, but I think this solution will result in less support for us.
greg0ire
force-pushed
the
remove-deprecation
branch
from
fe8e7b8
to
ca8cb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hesitated between this and removing the transaction helper entirely, but I think this solution will result in less support for us. Let me know if you think I should remove the transaction helper.