-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update Box #1333
build: Update Box #1333
Conversation
@greg0ire this probably requires a manual approval in order to trigger the CI |
I'm AFK but I think I might have wrongly configured the |
See #1290. Please add the sh file where relevant 🙏 |
@greg0ire you would need to merge it to 3.6.x, or should this target 3.5.x? (in which case so should the previous ones that were merged) |
3.5 is unmaintained. Looking at the work flow, paths is present, so I think my PR was merged up. I'll be AFK until Thursday, but feel free to open a merge up PR if you think stuff present in 3.5 is missing in 3.6 |
@theofidry I'm back from hols, I pushed a new commit so that the relevant jobs are triggered 🙂 |
@theofidry if this looks OK to you, please, mark it as ready for review and I'll merge :) |
I see the download of box but no building or test of the built PHAR, is that expected? |
As soon as the phar is available, the building and test do happen, but as a PHPUnit test, not as a separate github action: https://github.com/doctrine/migrations/blob/3.6.x/tests/Doctrine/Migrations/Tests/BoxPharCompileTest.php#L18-L70 |
Thanks @theofidry ! |
Should probably be updated to 4.4.0 now :) |
Working on it: #1365 |
Update to the latest Box version.
Depends on #1332