Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update Box #1333

Merged
merged 3 commits into from
Oct 15, 2023
Merged

build: Update Box #1333

merged 3 commits into from
Oct 15, 2023

Conversation

theofidry
Copy link
Contributor

Q A
Type improvement
BC Break no

Update to the latest Box version.

Depends on #1332

@theofidry theofidry marked this pull request as draft March 14, 2023 22:57
@theofidry
Copy link
Contributor Author

@greg0ire this probably requires a manual approval in order to trigger the CI

@greg0ire
Copy link
Member

I'm AFK but I think I might have wrongly configured the paths option in the github workflow.

@greg0ire
Copy link
Member

See #1290. Please add the sh file where relevant 🙏

@theofidry
Copy link
Contributor Author

@greg0ire you would need to merge it to 3.6.x, or should this target 3.5.x? (in which case so should the previous ones that were merged)

@greg0ire
Copy link
Member

3.5 is unmaintained. Looking at the work flow, paths is present, so I think my PR was merged up. I'll be AFK until Thursday, but feel free to open a merge up PR if you think stuff present in 3.5 is missing in 3.6

@greg0ire
Copy link
Member

greg0ire commented Mar 22, 2023

@theofidry I'm back from hols, I pushed a new commit so that the relevant jobs are triggered 🙂

@greg0ire greg0ire added this to the 3.6.1 milestone Mar 22, 2023
@greg0ire greg0ire added the CI label Mar 22, 2023
@greg0ire
Copy link
Member

@theofidry if this looks OK to you, please, mark it as ready for review and I'll merge :)

@theofidry theofidry marked this pull request as ready for review March 22, 2023 20:00
@theofidry
Copy link
Contributor Author

I see the download of box but no building or test of the built PHAR, is that expected?

@greg0ire
Copy link
Member

As soon as the phar is available, the building and test do happen, but as a PHPUnit test, not as a separate github action: https://github.com/doctrine/migrations/blob/3.6.x/tests/Doctrine/Migrations/Tests/BoxPharCompileTest.php#L18-L70

@greg0ire greg0ire merged commit f302e36 into doctrine:3.6.x Oct 15, 2023
@greg0ire
Copy link
Member

Thanks @theofidry !

@theofidry theofidry deleted the buid/box-update branch October 15, 2023 20:09
@theofidry
Copy link
Contributor Author

theofidry commented Oct 15, 2023

Should probably be updated to 4.4.0 now :)

@greg0ire
Copy link
Member

Working on it: #1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants