Raise PHPStan level to 8 #1409
Merged
Raise PHPStan level to 8 #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/phpstan-level-8
branch
from
de7e03b
to
77fe85e
Compare
| @@ -145,7 +145,7 @@ public function getConfiguration(): Configuration | |||
| { | |||
| if ($this->configuration === null) { | |||
| $this->configuration = $this->configurationLoader->getConfiguration(); | |||
| $this->freeze(); | |||
| $this->frozen = true; | |||
There was a problem hiding this comment.
Why these changes where the frozen() method gets replaced with the direct set to true?
There was a problem hiding this comment.
PHPStan treats the method calls as impure and complains that $this->configuration might be null when we return it.
There was a problem hiding this comment.
I was playing around with annotations and other configurations, but it seems like PHPStan can't be convinced that $this->freeze() does nothing evil with other property states.
There was a problem hiding this comment.
Yes, and this is fine imho. freeze() is impure, so PHPStan's behavior is correct.
SenseException
approved these changes
Mar 11, 2024
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Fix CS Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's make our static analysis a little bit stricter.