TableMetadataStorage - fix isAlreadyV3Format for the same version values

[kfrankiewicz]

Q	A
Type	bug
BC Break	no
Fixed issues	no link, the explanation below

Summary

Doctrine\Migrations\Metadata\Storage\TableMetadataStorage::isAlreadyV3Format() method was returning false even if both versions in the arguments have exactly the same value. E.g.:

       strpos(
            'Namespace\Version1234',
            'Namespace\Version1234'
        ) !== (
                strlen('Namespace\Version1234') -
                strlen('Namespace\Version1234')
            );

Compares 0 !== 0 what gives false, but isAlreadyV3Format() should return true when the versions are the same.

[SenseException]

Thank you.

I'd expect a test that covers the fixed behaviour.

[kfrankiewicz]

@SenseException Thanks for asking for the test. There was an issue! I've added the test.

[greg0ire]

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those.

[kfrankiewicz]

Done @greg0ire. Hope I haven't missed anything more.

[greg0ire]

Thanks @kfrankiewicz