Make configuration and dependency injection container immutable #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
immutable-configs
branch
from
e8c9c19
to
651aec5
Compare
Koc
reviewed
Nov 30, 2019
Koc
reviewed
Nov 30, 2019
greg0ire
reviewed
Nov 30, 2019
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DoctrineCommandTest.php
Outdated
Show resolved
Hide resolved
goetas
force-pushed
the
immutable-configs
branch
2 times, most recently
from
7835607
to
0bfb8ac
Compare
greg0ire
reviewed
Dec 1, 2019
goetas
force-pushed
the
immutable-configs
branch
from
0bfb8ac
to
a89d289
Compare
greg0ire
previously approved these changes
Dec 1, 2019
greg0ire
dismissed
their stale review
The build does not pass, will approve when it does
goetas
force-pushed
the
immutable-configs
branch
from
a89d289
to
aea823d
Compare
greg0ire
approved these changes
Dec 1, 2019
This avoids having other services hacking into the DI container or config object at runtime (avoiding inconsistent retrieval of services
goetas
force-pushed
the
immutable-configs
branch
from
aea823d
to
cb5d476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the configuration and dependency injection container immutable. (frozen state)
This avoids having other services hacking into the DI container or config object at runtime (avoiding inconsistent retrieval of services