Introduce query value object to wrap sql queries #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
query-value-object
branch
3 times, most recently
from
5c795fe
to
5ee2b89
Compare
greg0ire
reviewed
Jan 18, 2020
| * @param mixed[] $types | ||
| */ | ||
| public function __construct(string $statement, array $parameters = [], array $types = []) | ||
| { |
There was a problem hiding this comment.
What should happen if the number of parameters and the number of types is not the same?
There was a problem hiding this comment.
Good point. Will check what is doing doctrine DBAL, and do something similar
goetas
force-pushed
the
query-value-object
branch
from
7f7b3c7
to
c024f00
Compare
greg0ire
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think that the
Queryvalue object was a great idea proposed by @pulzarraider in #906. Independently if #906 is going to be merged, I see value in theQuerypart, so here is a full refactoring of the code base to use it everywhere instead of the current 3 different arrays holding the same data.