Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make missing inheritance declaration a failure #10463

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jan 26, 2023

This follows up on #10431: This kind of misconfiguration triggered a deprecation warning since 2.15.x. Now let's make it an exception.

@mpdude mpdude changed the base branch from 2.14.x to 3.0.x January 26, 2023 11:01
@mpdude mpdude changed the title activate 10431 Make missing inheritance declarations a failure in 3.0 Jan 26, 2023
@derrabus derrabus added this to the 3.0.0 milestone Jan 26, 2023
@derrabus derrabus changed the title Make missing inheritance declarations a failure in 3.0 Make missing inheritance declarations a failure Jan 26, 2023
@derrabus
Copy link
Member

Don't forget to update UPGRADE.md.

@mpdude mpdude marked this pull request as draft January 26, 2023 12:35
@mpdude mpdude changed the title Make missing inheritance declarations a failure Make missing inheritance declaration a failure on 3.0.x Jan 26, 2023
@mpdude mpdude marked this pull request as ready for review January 26, 2023 12:56
@mpdude mpdude marked this pull request as draft January 26, 2023 13:08
@derrabus derrabus changed the title Make missing inheritance declaration a failure on 3.0.x Make missing inheritance declaration a failure Jan 26, 2023
@derrabus
Copy link
Member

Your changes from 2.15.x have been merged up. Can you please rebase?

@mpdude mpdude force-pushed the activate-10431 branch 2 times, most recently from 1d13c68 to 7147b3e Compare January 27, 2023 09:53
This follows up on doctrine#10431: This kind of misconfiguration triggered a deprecation warning since 2.15.x. Now let's make it an exception.
@mpdude mpdude marked this pull request as ready for review January 27, 2023 09:54
@mpdude
Copy link
Contributor Author

mpdude commented Jan 27, 2023

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants