-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessary refactorings for Property hooks #11659
base: 3.4.x
Are you sure you want to change the base?
Conversation
…ternal reflection properties. no tests.
…ccessors at runtime.
What are the consequences for the persistence reflection namespace, and for the ODM? I suppose if there is code in persistence, it is because it is shared with the ODM? |
@greg0ire for now its just inline because this way its easier to test the changes fully without multi component changes. We can move the PropertyAccessors namespace into persistence if we think that will help for MongoDB. |
Should all the PropertyAccessor types be marked as internal so that moving them doesn't become a breaking change? |
namespace Doctrine\ORM\Mapping\PropertyAccessors; | ||
|
||
/** @internal */ | ||
interface PropertyAccessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a comment here would be good.
a property accessor is a class that allows to read and write private/protected properties on objects
we use them when … (during hydration and persistence?)
there are several implementations because…
This prepares the internals of
ClassMetadata
to go away from$reflFields
as an array of ReflectionProperty and sub-classes. This is problematic in PHP 8.4, because we need to usesetRawValueWithoutLazyInitialization
andgetRawValue
instead. In the existing inheritance heirachy this is going to be messy.This PR inlines the Persistence Reflection namespace into a new PropertyAccessors namespace and reworks the API to be wrappers of ReflectionProperty (aggregation) instead of inheritance. It also cleans up the code to avoid the references to old Doctrine proxy instances. You can access the new API via
ClassMetadata::$propertyAccessors
.The
PropertyAccessor
interface has just two methods:For backwards compatibility
ClassMetadata::$reflFields
is converted from array to a newLegacyReflectionFields
class that maps from property accessors to persistence-based reflection property instances. Accessing this structure emits a deprecation.Tasks
The actual support for property hooks should be done after this is merged in a seprate PR.