Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added straight_join to $reservedNewline #134

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Added straight_join to $reservedNewline #134

merged 3 commits into from
Aug 5, 2024

Conversation

MaximilianKresse
Copy link
Contributor

@MaximilianKresse MaximilianKresse commented Aug 5, 2024 •
edited
Loading

Expected formatting:

SELECT
  *
FROM
  test 
  STRAIGHT_JOIN test2 ON test.id = test2.id

Current formatting:

SELECT
  *
FROM
  test STRAIGHT_JOIN test2 ON test.id = test2.id

@derrabus
Copy link
Member

derrabus commented Aug 5, 2024

Can we add a test for this change?

@MaximilianKresse MaximilianKresse changed the title Moved straight_join to $reservedNewline Added straight_join to $reservedNewline Aug 5, 2024
@greg0ire greg0ire merged commit 7f83911 into doctrine:1.4.x Aug 5, 2024
10 checks passed
@greg0ire
Copy link
Member

greg0ire commented Aug 5, 2024

Thanks @MaximilianKresse !

@greg0ire greg0ire added this to the 1.4.1 milestone Aug 5, 2024
@greg0ire greg0ire added the bug Something isn't working label Aug 5, 2024
@github-actions github-actions bot mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximilianKresse @derrabus @greg0ire