forked from postwait/node-amqp
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added the fix suggested in postwait#300 to prevent econnreset.
- Loading branch information
Dennis Meerveld
committed
Jun 23, 2015
1 parent
f64704d
commit 5489797
Showing
2 changed files
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5489797
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you ever work on a pull request to get this merged into the postwait/node-amqp project. I just made the same change you have in this commit and it fixed the ECONNRESET error I was seeing as well.
5489797
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more digging (referencing the Node.js docs), calling
.end()
on the socket is preferrable, as theconnectionCloseOk
case is currently set to do. This ECONNRESET error looks like it's coming from RabbitMQ as part of their socket implementation.I am going to proceed with 0.2.6 of the postwait library and suppress the ECONNRESET when I know that I have closed the socket from my end.