Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix some flaky tests #10

Merged
merged 3 commits into from
Apr 20, 2023
Merged

core: fix some flaky tests #10

merged 3 commits into from
Apr 20, 2023

Conversation

DarianShawn
Copy link
Collaborator

Description

Merge upstream fix 1379.

The tests panic quite frequently.

Rationale

The tests no longer panic. I manager to trigger the error (almost) every time with this command:

seq 1 10 | parallel go test -count=1 ./eth/downloader -run "TestCanonicalSynchronisation66Full" -v

@DarianShawn DarianShawn added the bug Something isn't working label Apr 20, 2023
@DarianShawn DarianShawn self-assigned this Apr 20, 2023
@0xcb9ff9 0xcb9ff9 mentioned this pull request Apr 20, 2023
Closed
0xcb9ff9
0xcb9ff9 approved these changes Apr 20, 2023
View reviewed changes
Copy link

@0xcb9ff9 0xcb9ff9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xcb9ff9 0xcb9ff9 merged commit ff17138 into dev Apr 20, 2023
@0xcb9ff9 0xcb9ff9 deleted the fix-tests-panic branch April 20, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xcb9ff9 0xcb9ff9 0xcb9ff9 approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@DarianShawn DarianShawn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarianShawn @0xcb9ff9 @brilliant-lx