eth/fetcher: remove Re-queue blocks #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xcb9ff9
requested review from
DarianShawn and
abrahamcruise321
as code owners
0xcb9ff9
force-pushed
the
fix/block-fetcher-re-queue
branch
from
5afb237
to
72428a6
Compare
DarianShawn
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
revert bsc change,
BlockFetcher.requeueandBlockFetcher.downis are two mutually exclusive state channels, and the here triggers both,don't needrequeuestatusdbsc/eth/fetcher/block_fetcher.go
Lines 851 to 852 in 96778f1