Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: Add genesis flag #9

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

0xcb9ff9
Copy link

Description

add --genesis flag, ignore read genesis block from database

Rationale

SetEthConfig adds process for handling Genesis JSON file

Example

./geth --datadir=/data/dbsc --genesis=/data/genesis-dbsc-devnet.json

Changes

Notable changes:

  • add --genesis flag

@0xcb9ff9 0xcb9ff9 added the enhancement New feature or request label Apr 18, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Apr 18, 2023
@0xcb9ff9 0xcb9ff9 changed the title cmd/geth: add genesis flag cmd/geth: Add genesis flag Apr 18, 2023
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to confirm.
And re-run unit-test action to make it pass?

cmd/utils/flags.go Outdated Show resolved Hide resolved
@0xcb9ff9 0xcb9ff9 changed the base branch from dev to ibft-consensus April 18, 2023 06:54
@0xcb9ff9 0xcb9ff9 merged commit 8a24529 into ibft-consensus Apr 18, 2023
@0xcb9ff9 0xcb9ff9 deleted the feature/genesis-flag branch April 18, 2023 06:58
DarianShawn pushed a commit that referenced this pull request Apr 19, 2023
### Description

add `--genesis` flag, ignore read genesis block from database

### Rationale

`SetEthConfig` adds process for handling Genesis JSON file

### Example

```sh
./geth --datadir=/data/dbsc --genesis=/data/genesis-dbsc-devnet.json
```

### Changes

Notable changes: 
* add `--genesis` flag
@0xcb9ff9 0xcb9ff9 mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants