Add option to round depth values when using a depth format fallback #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a higher precision depth format
Assassin's Creed Brotherhood, SimCity and The Saboteur
|
This is a disgusting solution. I think I'd rather hack in an additional bias to depth compare sample ops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2642
Might help #2361
Does not fix #1560
I'm not sure if this is the correct fix or if the underlying issue is somewhere else.
The shadow map bias in ACB appears to be too small, so it ends up relying on rounding inaccuracies.
It's entirely possible that we have small floating point math inaccuracies somewhere else but I have no clue how we'd debug that.
This should at least fix the issue even though it's pretty awful.