-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[util] Add new "Zusi 3" exe filename #3315
Conversation
In addition to the legacy "ZusiSim.exe" executable, the recent 3.5 release added a 64-bit "ZusiSim.64.exe" executable. This is now the default executable when launching the game in Steam. The game is unplayable without this option, so update the regex for Zusi 3. Fixes doitsujin#3250.
Updated commit message to add "Fixes #3250.". Also, I have now verified that the regex still works for the 32-bit exe filename "ZusiSim.exe" after updating 32 bit dxvk dlls in the compatdata wine prefix (launching it from the command line using Proton's wine executable and the compatdata wine prefix simply works as expected, I thought there would be some DRM/Steam issues). |
Thanks for the PR. |
That's a great question! I've never used these editors and don't really know how to use them (they seem complicated), but giving them a very superficial test:
|
Thanks for the extra testing. I have asked besentv if he has any input on the last exe. Edit: Would you be able to make a issue for the |
Sure, I'll try to find out what is going on, and then open an issue (if I can't find an existing issue for this problem). Thanks for the review :-) |
Not sure where to put this, about the ZusiFtdEditor.64.exe issue: I suspect it may not be a dxvk bug after all. There are two layers in that editor preview feature: The rendered cab view image itself (D3D9) as it would appear in the game, and an additional layer on top of it that draws rectangles around selected elements in the cab view. When using dxvk, only the "rectangle layer" is visible with gray areas inside and inbetween rectangles, instead of the cab view image. When not using dxvk, only the cab view layer is visible and rectangles are missing. So maybe dxvk is actually less buggy here, and wine just needs to learn to make those pixels in the "rectangle layer" that are not actually part of a rectangles transparent instead of opaque gray – or something along those lines. So I'd consider it "not a dxvk bug" for now. |
Hopefully the regex is correct. It works for ZusiSim.64.exe (which is the executable launched by steam), but I'm not sure how to launch the legacy 32 bit "ZusiSim.exe" in steam, so I have not tested if that still works correctly.
Commit message:
In addition to the legacy "ZusiSim.exe" executable, the recent 3.5 release added a 64-bit "ZusiSim.64.exe" executable. This is now the default executable when launching the game in Steam. The game is unplayable without this option, so update the regex for Zusi 3.
Fixes #3250.