Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Add dxvk.maxChunkSize 1 for Origin Web Helper Service and Ubisoft Connect (UPlay) #4047

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

Tiagoquix
Copy link
Contributor

A follow-up to #4037.

Tested by exiting Steam completely, then launching with DXVK_CONFIG="dxvk.maxChunkSize = 1" steam and playing Watch Dogs 1 for about 5 minutes. Haven't experienced any problems.

Below are the processes that stay open with the game in the background:
ubisoft

UbisoftConnect.exe is the main process, which doesn't stay open, but I'm adding it for extra safety. upc.exe seems to be what really matters here (I guess it means "UPlay Core").

We also have these ones in the Ubisoft Game Launcher installation folder:

  • UbisoftGameLauncher64.exe and UbisoftGameLauncher.exe (opens temporarily during Steam game launch; maybe a proxy service for Steam-Ubisoft?)
  • UplayCrashReporter.exe (I don't think this one needs maxchunksize)
  • UplayWebCore.exe (probably related to the overlay, but the UPlay overlay causes issues on Linux and Lutris even disables it by editing a config. file)
  • UbisoftExtension.exe and UplayService.exe (I have no idea, but they do not stay open with the game)

Feel free to add maxchunksize for any process mentioned before that I haven't added if you have a better reasoning.

To be clear, Ubisoft does not support its legacy launcher anymore, and forces the new one onto its users, so there's no point to add UPlay-exclusive-related process names here.

Thank you for your attention.

@Tiagoquix
Copy link
Contributor Author

I also added the Origin Web Helper service (it's basically Chromium overlay for Origin) and corrected(?) the Rockstar-related names.

Not sure if my syntax is correct. The spaces seem wrong, but I'm not 100% sure if they really are wrong.

@Tiagoquix Tiagoquix changed the title Add dxvk.maxChunkSize 1 to Ubisoft Connect (UPlay) Add dxvk.maxChunkSize 1 to Ubisoft Connect (UPlay) + Origin Web Helper Service + misc. changes to Rockstar-related Jun 2, 2024
@Tiagoquix Tiagoquix marked this pull request as draft June 2, 2024 10:33
@Tiagoquix Tiagoquix changed the title Add dxvk.maxChunkSize 1 to Ubisoft Connect (UPlay) + Origin Web Helper Service + misc. changes to Rockstar-related [util] Changes related to dxvk.maxChunkSize 1 Jun 2, 2024
src/util/config/config.cpp Outdated Show resolved Hide resolved
src/util/config/config.cpp Outdated Show resolved Hide resolved
src/util/config/config.cpp Outdated Show resolved Hide resolved
src/util/config/config.cpp Outdated Show resolved Hide resolved
@Tiagoquix
Copy link
Contributor Author

@Blisto91 Many thanks for your help. The PR is what I initially wanted now.

For extra safety, I kept the folders.

@Tiagoquix Tiagoquix marked this pull request as ready for review June 2, 2024 11:44
@Tiagoquix Tiagoquix requested a review from Blisto91 June 2, 2024 11:44
@Tiagoquix Tiagoquix changed the title [util] Changes related to dxvk.maxChunkSize 1 [util] Add dxvk.maxChunkSize 1 for Origin Web Helper Service and Ubisoft Connect (UPlay) Jun 2, 2024
@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented Jun 2, 2024

Please consider a squash merge to avoid unnecessary commits.

@doitsujin doitsujin merged commit ee18aec into doitsujin:master Jun 2, 2024
4 checks passed
@doitsujin
Copy link
Owner

This band-aid is getting annoying and we really need to find a way to make this the default behaviour for all apps, but well, guess the band-aid fixes will do for now.

@Tiagoquix
Copy link
Contributor Author

Nothing is more permanent than a temporary solution. 🍷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants