Fixed GLFW exception at startup #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GlfwWsiDriver::getInstanceExtensions` was creating an `std::vector` with a size argument in the ctor but then used `push_back` instead of filling the pre-allocated elements, leading to a bunch of nullptr entries at the start that caused an exception later on when accessed.
Sanakan8472
added a commit
to ezEngine/ezEngine
that referenced
this pull request
Jun 7, 2024
* Add experimental support for DXVK-native on Linux
This allows compiling the DX11 renderer on Linux. The main goal is to make it easier to make renderer changes on Linux without having to boot Windows. To use:
1. Clone DXVK
1. Change `meson.build` to `lib_glfw = dependency('glfw3', required: false)` instead of just `'glfw'`.
1. Run `./package-native.sh master ~/libDXVK --no-package`
1. `export PKG_CONFIG_PATH="~/libDXVK/dxvk-native-master/usr/lib/pkgconfig"`
1. Enable `EZ_BUILD_EXPERIMENTAL_DXVK`
Note that you won't be able to run this without considerable effort so right now it's merely to make sure the code compiles:
1. There is no shader compiler so if you want to run DX11, you need to get a shader cache from a Windows machine or from the Windows CI build artifacts.
3. We conflict between two GLFW versions as EZ does not use the system version but DXVK does. You can delete our version and replace it with the system version but it's tedious.
4. For some reason you can't load two renderers at the same time under Linux. Sub-system init for DX11 is simply skipped. Can't figure out why.
5. Latest release of dxvk has a bug, so you need to apply at least this patch: doitsujin/dxvk#4061
6. You need to set the env var `DXVK_WSI_DRIVER=GLFW` before running any app.
flibitijibibo
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlfwWsiDriver::getInstanceExtensionswas creating anstd::vectorwith a size argument in the ctor but then usedpush_backinstead of filling the pre-allocated elements, leading to a bunch of nullptr entries at the start that caused an exception later on when accessed.