Remove supplementary contexts from swap chains #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
swapchain-raw-vulkan
branch
5 times, most recently
from
d659ebe
to
5fd0da4
Compare
Also provide the descriptor pool for convenience.
Temporarily disable the HUD until that is refactored too.
We want to be able to invoke compute shaders during init commands.
And reintroduce cmdResetQueryPool.
And change how rendering works in general so that we emit fewer draw calls.
Mostly convenience, but we do want to get rid of Begin/EndRecording at some point.
Do everything on the main context instead. Also only present once regardless of sync interval.
Otherwise, layout tracking might track a dead image and get confused.
doitsujin
force-pushed
the
swapchain-raw-vulkan
branch
from
02b4b2c
to
9654ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically does part of what #4269 did. Rendering code for the swap chain blitter and HUD were rewritten to use plain Vulkan in order to not mess with context state.
This will allow us to implement support forAddedSEQUENTIALpresent modes in D3D11 in a future PR.SWAP_EFFECT_{FLIP}_SEQUENTIALsupport here since it's trivial now.Needs a lot of testing since the swap chain code as a whole is quite brittle, tagging @K0bin mostly for the D3D9 part.