Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visualize function without storage #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mfogelson
Copy link
Collaborator

Merge branch 'visualize-function'

Incorporate the addition to the visualize function, eliminating the need for storage input.

A bug fix has also been implemented to allow users to set the joint_radius parameter during visualization explicitly. This gives users more control over the visual aspect of the system.

This merge integrates the changes from the visualize-function branch, integrating these improvements into the main branch.

Authors: Mitchell Fogelson [email protected]

@mfogelson mfogelson added the enhancement New feature or request label Jun 15, 2023
@mfogelson mfogelson self-assigned this Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #89 (10bfe7a) into main (7b6c368) will decrease coverage by 0.15%.
The diff coverage is 11.11%.

❗ Current head 10bfe7a differs from pull request most recent head 6c22ee5. Consider uploading reports for the commit 6c22ee5 to get more accurate results

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   87.51%   87.37%   -0.15%     
==========================================
  Files          89       89              
  Lines        5086     5092       +6     
==========================================
- Hits         4451     4449       -2     
- Misses        635      643       +8     
Impacted Files Coverage Δ
src/visuals/visualizer.jl 69.13% <11.11%> (-2.66%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@janbruedigam janbruedigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple test for this function?

@@ -242,7 +279,7 @@ function animate_node!(storage::Storage{T,N}, id, shape, animation, shapevisuali
x = storage.x[id][i]
q = storage.q[id][i]
atframe(animation, frame_id) do
set_node!(x, q, shape, shapevisualizer, showshape)
set_node!(x, q, shape, shapevisualizer, showshape)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove identation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants