Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse assets from index.html (#127) #131

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

mwistrand
Copy link
Contributor

  • Parse, copy, and hash <img src>, <script src>, and <link href>
    assets from src/index.html.
  • Update the CSS rules to limit processing to the src/ and tests/
    directories.
  • Ignore all assets imported from the assets/ directory.
  • Change Dojo 2 to Dojo in README.md.
  • Add the ico extension to the images rule.

This commit has already been merged to next, but now requires a separate PR to master.

@mwistrand mwistrand requested a review from agubler August 13, 2018 13:42
@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #131 into master will decrease coverage by 0.04%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   59.76%   59.71%   -0.05%     
==========================================
  Files           8        8              
  Lines         425      427       +2     
  Branches       94       92       -2     
==========================================
+ Hits          254      255       +1     
- Misses        171      172       +1
Impacted Files Coverage Δ
src/base.config.ts 28.57% <25%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef169b...9da143c. Read the comment docs.

- Parse, copy, and hash `<img src>`, `<script src>`, and `<link href>`
   assets from `src/index.html`.
- Update the CSS rules to limit processing to the `src/` and `tests/`
   directories.
- Ignore all assets imported from the `assets/` directory.
- Change Dojo 2 to Dojo in README.md.
- Add the `ico` extension to the images rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants