Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate css vars #219

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 7, 2018

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Use OptimizeCssAssetsPlugin with cssnano to remove duplicates from the css assets.

@agubler agubler added the v4 label Dec 7, 2018
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #219 into v4 will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##              v4     #219      +/-   ##
=========================================
- Coverage   52.7%   52.67%   -0.03%     
=========================================
  Files         10       10              
  Lines        573      579       +6     
  Branches     140      141       +1     
=========================================
+ Hits         302      305       +3     
- Misses       271      274       +3
Impacted Files Coverage Δ
src/base.config.ts 23.49% <50%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13dacf8...c3fcd55. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants