Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move externals plugin into configs #234

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

mwistrand
Copy link
Contributor

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Move the ExternalLoaderPlugin into the configs since it must be registered after the HtmlWebpackPlugin in order to function correctly.

Resolves dojo/webpack-contrib#119

Move the ExternalLoaderPlugin into the configs since it must be
registered after the HtmlWebpackPlugin in order to function correctly.
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #234 into master will decrease coverage by 0.36%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #234      +/-   ##
=========================================
- Coverage   52.97%   52.6%   -0.37%     
=========================================
  Files          10      10              
  Lines         606     614       +8     
  Branches      148     154       +6     
=========================================
+ Hits          321     323       +2     
- Misses        285     291       +6
Impacted Files Coverage Δ
src/base.config.ts 22.85% <ø> (-0.05%) ⬇️
src/dev.config.ts 21.42% <25%> (+0.27%) ⬆️
src/dist.config.ts 31.74% <25%> (-0.46%) ⬇️
src/base.test.config.ts 13.79% <25%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95418c0...c6ae27a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants