Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ".bundle." from filenames #384

Closed
wants to merge 1 commit into from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Mar 16, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:
This simply removes .bundle. from all dist bundle files. The inclusion of bundle in the filename makes it more difficult to pull in main.js in both the dist and dev builds from an external file (used by parade to run tests in the browser). Unless there's a reason this was done in the first place removing the .bundle. would make supporting that much easier.

@maier49 maier49 changed the title Remove bundle from filenames Remove .bundle. from filenames Mar 16, 2020
@maier49 maier49 changed the title Remove .bundle. from filenames Remove ".bundle." from filenames Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   48.65%   48.65%           
=======================================
  Files          10       10           
  Lines         705      705           
  Branches      204      204           
=======================================
  Hits          343      343           
  Misses        362      362
Impacted Files Coverage Δ
src/dist.config.ts 27.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4d5f6...5d85687. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant